davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1611468553
##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -886,6 +886,12 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
regval |= STM32_PWR_CR3_SCUEN;
putreg32(regval, STM32_PWR_CR3);
+#elif defined(CONFIG_STM32H7_PWR_LDO_SUPPLY)
+ regval = getreg32(STM32_PWR_CR3);
+ regval &= ~(STM32_PWR_CR3_BYPASS | STM32_PWR_CR3_SCUEN |
+ STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
+ regval |= STM32_PWR_CR3_LDOEN;
+ putreg32(regval, STM32_PWR_CR3);
#else
Review Comment:
Add Comment as to what mode this else is.
##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -284,11 +284,24 @@ config STM32H7_HAVE_SMPS
bool
default n
+choice
+ prompt "STM32 H7 Power Supply Selection"
+ default STM32H7_PWR_DIRECT_SMPS_SUPPLY
Review Comment:
I do not think the default is correct. Before the change the what branch of
the
https://github.com/apache/nuttx/pull/12394/files#diff-9dfe671931738d39252fc8e902e892d172ac118551d14e1a454e324edb0d0be4R889-R897
would have been selected.
We have to be super carful here not break existing boards. That had the
default set BEFORE this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
