jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618084948


##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -284,11 +284,55 @@ config STM32H7_HAVE_SMPS
        bool
        default n
 
-config STM32H7_PWR_DIRECT_SMPS_SUPPLY
-       bool "Use direct SMPS supply mode"
+choice
+       prompt "STM32 H7 Power Supply Selection"

Review Comment:
   I removed the 'STM32H7_PWR_DEFAULT_SUPPLY' macro in Kconfig.
   
   I tried setting the 'STM32H7_HAVE_SMPS' macro in Kconfig to other chips.
   - The "STM32 H7 Power Supply Selection" menu does not appear for STM32H7x3xx
   - The "STM32 H7 Power Supply Selection" menu appears for STM32H7x5xx or 
STM32H7x7xx
   



##########
arch/arm/src/stm32h7/Kconfig:
##########
@@ -284,11 +284,55 @@ config STM32H7_HAVE_SMPS
        bool
        default n
 
-config STM32H7_PWR_DIRECT_SMPS_SUPPLY
-       bool "Use direct SMPS supply mode"
+choice
+       prompt "STM32 H7 Power Supply Selection"
+       default STM32H7_PWR_DEFAULT_SUPPLY
        depends on STM32H7_HAVE_SMPS
+       ---help---
+           The STM32H7x5 and STM32H7x7 support power supply configrations for 
the VCORE core domain and an external supply,
+           by configuring the SMPS step-down converter and voltage regulator.
+           Note:The SMPS step-down converter is not available on all packages.
+
+        Select the power supply mode of your board
+           - ID:1 LDO supply mode used 'STM32H7_PWR_LDO_SUPPLY' macro

Review Comment:
   This ID is from the data sheet (Reference manual RM0399).
   Power control (PWR)
   - Figure 22. System supply configurations
   
![Figure22](https://github.com/apache/nuttx/assets/113963003/18d36af0-652f-4a6b-b032-d0970c4ace03)
   
   - Table 33. Supply configuration control
   
![Table33](https://github.com/apache/nuttx/assets/113963003/aa00822a-cdfd-4f3b-9601-3c4ac416c8a7)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to