davids5 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1618664670
##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -886,6 +886,20 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
regval |= STM32_PWR_CR3_SCUEN;
putreg32(regval, STM32_PWR_CR3);
+#elif defined(CONFIG_STM32H7_PWR_LDO_SUPPLY)
+ regval = getreg32(STM32_PWR_CR3);
+ regval &= ~(STM32_PWR_CR3_BYPASS | STM32_PWR_CR3_SCUEN |
+ STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
+ regval |= STM32_PWR_CR3_LDOEN;
+ putreg32(regval, STM32_PWR_CR3);
+#elif defined(CONFIG_STM32H7_PWR_SMPS_LDO) || \
+ defined(CONFIG_STM32H7_PWR_EXT_SMPS_LDO) || \
+ defined(CONFIG_STM32H7_PWR_EXT_SMPS_BYPASS) || \
+ defined(CONFIG_STM32H7_PWR_BYPASS)
+ /* These 4 cases of power supply mode have no macros created.
+ * Selecting one of these modes will cause a compile error.
+ */
+ #error Macro of this power supply mode is not created yet.
Review Comment:
The correct thing to do is: The Kconfig should name the 6 configurations
available based on the package and IC Family and the code should set them. The
default should be what it was before this PR.
Putting a partial solution and jeopardizing breaking existing boards is
totally un-acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
