jfbblue0922 commented on code in PR #12394:
URL: https://github.com/apache/nuttx/pull/12394#discussion_r1613328576
##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -886,7 +886,19 @@ void stm32_stdclockconfig(void)
STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
regval |= STM32_PWR_CR3_SCUEN;
putreg32(regval, STM32_PWR_CR3);
+#elif defined(CONFIG_STM32H7_PWR_LDO_SUPPLY)
+ regval = getreg32(STM32_PWR_CR3);
+ regval &= ~(STM32_PWR_CR3_BYPASS | STM32_PWR_CR3_SCUEN |
+ STM32_PWR_CR3_SMPSEXTHP | STM32_PWR_CR3_SMPSLEVEL_MASK);
+ regval |= STM32_PWR_CR3_LDOEN;
+ putreg32(regval, STM32_PWR_CR3);
#else
+ /* 4 else cases of power supply mode
Review Comment:
@davids5
STM32H7 has six power supply modes to choose from.
We use LDO supply.
I suspect someone is using a DIRECT SMPS supply.
And I don't know what the first person used.
So we don't know what the 'else' power mode is.
'else' is considered to be when nothing is defined, but I don't know how to
change 'default' from 'defining nothing' in 'Kconfig'.
What do you think we should do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
