patacongo edited a comment on pull request #1187: URL: https://github.com/apache/incubator-nuttx/pull/1187#issuecomment-642142655
In general, I think these changes are pretty ill-conceived. But I have not looked at all of the details; that is just my impression. There are many good ideas mish-mashed together with some not so good ideas. I don't think it should go to master. It should be broken up into multiple PRs that can be reviewed, approved, and merged. It should never come into master in this form (and we still do not want to perturb the code base prior the branching off 9.1!). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
