patacongo commented on a change in pull request #1187:
URL: https://github.com/apache/incubator-nuttx/pull/1187#discussion_r438321525
##########
File path: sched/pthread/pthread_cleanup.c
##########
@@ -173,8 +165,7 @@ void pthread_cleanup_push(pthread_cleanup_t routine, FAR
void *arg)
*/
sched_lock();
- if ((tcb->cmn.flags & TCB_FLAG_TTYPE_MASK) == TCB_FLAG_TTYPE_PTHREAD &&
- tcb->tos < CONFIG_PTHREAD_CLEANUP_STACKSIZE)
+ if (tcb->tos < CONFIG_PTHREAD_CLEANUP_STACKSIZE)
Review comment:
To me it is a totally unacceptable partitioning of user space and kernel
interfaces. I am very opposed to supported this. It is wrong. It is a
serious architectural mistake. Let's not go that way... it is very sickening
design concept. Let's keep logic in place to prohibit the use of any pthread
APIs from kernel threads. Please. Don't shit on the OS! We are entrusted you
to maintain good functional partitioning and not to trash all of the interfaces.
I am super opposed to the concept. I am very disappointed in what you are
doing to the OS. Very disappointed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
