yamt commented on PR #14416:
URL: https://github.com/apache/nuttx/pull/14416#issuecomment-2425612894

   > > is the "functional safety requirements" documented somewhere? or, is it 
just your internal requirement, which doesn't matter much for the nuttx project?
   > 
   >     1. We haven't fully passed ISO26262 yet, so most of the changes are 
not suitable for upstream.
   
   i don't understand how ISO26262 is related here.
   but i guess you meant "not ready for upstream yet, but maybe in future", 
right?
   if it isn't ready, maybe it's an option to keep this in your internal branch 
along with the rest of the necessary changes for now?
   
   >     2. All task creation will be bound to fd 0/1/2, why do we need to 
allocate for additional memory segment?
   
   it seems to have an obvious downside.
   
   * waste memory when the file lists are extended
   * waste memory if CONFIG_NFILE_DESCRIPTORS_PER_BLOCK is too big
   
   that is, when the workload on the system is not static as yours.
   
   also, the associated code/structural complexity (which might caused the 
crash @Donny9 was observing, i dunno) can be considered as another downside.
   
   > most kernel tasks will not needs additional file descriptors.
   
   while i agree about the kernel threads, this stuff is not limited to kernel 
threads, is it?
   
    (well, actually i personally tend to think kernel threads should not use 
file descriptors at all.
   but i guess it's a separate topic.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to