anchao commented on PR #14416: URL: https://github.com/apache/nuttx/pull/14416#issuecomment-2425622149
> it seems to have an obvious downside. > > * waste memory when the file lists are extended > * waste memory if CONFIG_NFILE_DESCRIPTORS_PER_BLOCK is too big > > that is, when the workload on the system is not static as yours. > I think you should read this part of the code further. PR #11850 just replace dynamic allocation to static definition. It does not waste any memory. > also, the associated code/structural complexity (which might caused the crash @Donny9 was observing, i dunno) can be considered as another downside. This flaw should be solved in a more elegant fix instead of revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
