xiaoxiang781216 commented on code in PR #15669:
URL: https://github.com/apache/nuttx/pull/15669#discussion_r1926914861
##########
sched/Kconfig:
##########
@@ -2011,6 +2011,7 @@ config ASSERT_PAUSE_CPU_TIMEOUT
config COREDUMP
bool "Coredump support"
depends on ARCH_HAVE_TCBINFO
+ select LIBC_ARCH_ELF
Review Comment:
> could we bring back coredump back to elf or modlib?
It consumes too much code space, it's fine to move to modlib if you can make
that the difference is small(< 1KB) after moving to modlib.
> I really don't like the current directory structure. Why should elf be
placed in sched?
module/ also locate in sched/ folder which use libs/libc/modlib, so it's
also fine to locate coredump inside sched/misc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
