xiaoxiang781216 commented on code in PR #15669:
URL: https://github.com/apache/nuttx/pull/15669#discussion_r1927099342
##########
sched/Kconfig:
##########
@@ -2011,6 +2011,7 @@ config ASSERT_PAUSE_CPU_TIMEOUT
config COREDUMP
bool "Coredump support"
depends on ARCH_HAVE_TCBINFO
+ select LIBC_ARCH_ELF
Review Comment:
But it bring in the whole elf parse code even nobody call any load function.
If you think that coredump in Linux is a good design, the recent change you
made for uio should be reverted since it isn't good to keep both read/write,
readv/writev callback in file_operations.
Anyway, if you can avoid to bring elf parser code, it's fine to revert to
the previous approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
