anchao commented on code in PR #15669:
URL: https://github.com/apache/nuttx/pull/15669#discussion_r1927052955


##########
sched/Kconfig:
##########
@@ -2011,6 +2011,7 @@ config ASSERT_PAUSE_CPU_TIMEOUT
 config COREDUMP
        bool "Coredump support"
        depends on ARCH_HAVE_TCBINFO
+       select LIBC_ARCH_ELF

Review Comment:
   modlib used to be the backend of dlfunc. No one used it in xiaomi's project. 
right? The logic was duplicate and I did not deny the benefits of removing 
elf/modlib.
   
   I am now talking about how to decouple elf coredump from sched. You can look 
at linux, the structure is very clear.
   https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c#L101-L109
   
![image](https://github.com/user-attachments/assets/fe836404-4828-4d4a-bbcc-a43f4bb12255)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to