xiaoxiang781216 commented on code in PR #15669:
URL: https://github.com/apache/nuttx/pull/15669#discussion_r1927003352
##########
sched/Kconfig:
##########
@@ -2011,6 +2011,7 @@ config ASSERT_PAUSE_CPU_TIMEOUT
config COREDUMP
bool "Coredump support"
depends on ARCH_HAVE_TCBINFO
+ select LIBC_ARCH_ELF
Review Comment:
> > It consumes too much code space, it's fine to move to modlib if you can
make that the difference is small(< 1KB) after moving to modlib.
>
> modlib does not have the coredump capability, right? why consume too much
code space.
>
The old implementation include a bunch of elf parser code into final image
even the user just enable coredump.
> elf is a set of capabilities, coredump is a subset, which should not have
anything relative with scheduler
the initialization and trigger of coredump always happen in sched/misc, the
only difference is that the new approach move the coredump generation from
binfmt to sched/misc. As I said before, if you can keep the code size < 1KB,
it's fine to move the coredump generation back to modlib(binfmt).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
