kywwilson11 commented on code in PR #16904: URL: https://github.com/apache/nuttx/pull/16904#discussion_r2301947553
########## include/nuttx/analog/ioctl.h: ########## @@ -131,6 +131,11 @@ #define AN_ADS7046_FIRST (AN_MCP47X6_FIRST + AN_MCP47X6_NCMDS) #define AN_ADS7046_NCMDS 3 +/* See arch/arm/src/stm32h5/stm32_adc.h */ + +#define AN_STM32H5_FIRST (AN_ADS7046_FIRST + AN_ADS7046_NCMDS) +#define AN_STM32H5_NCMDS 5 + Review Comment: I don't really appreciate the ! in your comment. I did this, because if you look at analog/ioctl.h, the stm32l4 is listed there. So there is precedent. Why was this allowed in the first place? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
