acassis commented on code in PR #16904: URL: https://github.com/apache/nuttx/pull/16904#discussion_r2301977160
########## include/nuttx/analog/ioctl.h: ########## @@ -131,6 +131,11 @@ #define AN_ADS7046_FIRST (AN_MCP47X6_FIRST + AN_MCP47X6_NCMDS) #define AN_ADS7046_NCMDS 3 +/* See arch/arm/src/stm32h5/stm32_adc.h */ + +#define AN_STM32H5_FIRST (AN_ADS7046_FIRST + AN_ADS7046_NCMDS) +#define AN_STM32H5_NCMDS 5 + Review Comment: @kywwilson11 don't get the typed words as offence or something bad. You are right, there are many precedents not only in the analog/ioctl.h, but in many other ioctl.h files. But we want to unify the analog ioctls, this way all drivers will use the same set of ioctls (with some ioctls only supported by some devices) We had a discussion with @nmaggioni some days ago about it. So it should be nice if you could participate of this discussion to define these unified analog ioctl set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
