raiden00pl commented on code in PR #16904: URL: https://github.com/apache/nuttx/pull/16904#discussion_r2303081749
########## include/nuttx/analog/ioctl.h: ########## @@ -131,6 +131,11 @@ #define AN_ADS7046_FIRST (AN_MCP47X6_FIRST + AN_MCP47X6_NCMDS) #define AN_ADS7046_NCMDS 3 +/* See arch/arm/src/stm32h5/stm32_adc.h */ + +#define AN_STM32H5_FIRST (AN_ADS7046_FIRST + AN_ADS7046_NCMDS) +#define AN_STM32H5_NCMDS 5 + Review Comment: @kywwilson11 I'm sorry if it sounded rude, I didn't mean to :) You're right that the STM32L4 specific ioctls are present in this file, but they shouldn't be (these is easy to generalize). Previously, we didn't pay enough attention to unifying interfaces for peripheral drivers, which led to quite a mess and a lack of portability between ADCs. This contradicts the `INVIOLABLES.md` and is generally bad engineering practice, the sooner we fix it, the better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
