Re: [PR] sched_lock: remove the check for whether tcb is NULL [nuttx]

via GitHub Mon, 10 Nov 2025 23:19:06 -0800


hujun260 commented on code in PR #17300:
URL: https://github.com/apache/nuttx/pull/17300#discussion_r2513103618



##########
sched/sched/sched_lock.c:
##########
@@ -76,13 +76,13 @@ void sched_lock(void)
        * integer type.
        */
 
-      DEBUGASSERT(rtcb == NULL || rtcb->lockcount < MAX_LOCK_COUNT);
+      DEBUGASSERT(rtcb && rtcb->lockcount < MAX_LOCK_COUNT);

Review Comment:
   I have tested some QEMU Armv8-M scenarios, and null pointers do not 
necessarily trigger errors.
   code
   
![img_v3_02ru_6ace5966-d5b2-4ea0-b202-bf7c5df0eeag](https://github.com/user-attachments/assets/0320c493-87e5-47de-be9f-f3432001c5e9)
   
   compile:
   ./tools/configure.sh -l mps3-an547:nsh ;make -j20
   run:
   qemu-system-arm -M mps3-an547 -nographic -kernel nuttx.bin
   
   
   
![img_v3_02ru_8d083bd8-1c8d-4fe7-a573-b24df014cc6g](https://github.com/user-attachments/assets/4eb20183-4527-44d5-846f-4d17c671e9f1)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] sched_lock: remove the check for whether tcb is NULL [nuttx]

Reply via email to