xiaoxiang781216 commented on code in PR #17011:
URL: https://github.com/apache/nuttx/pull/17011#discussion_r2684606064
##########
boards/arm/fvp-v8r-aarch32/fvp-armv8r-aarch32/include/board.h:
##########
@@ -33,4 +33,10 @@
* Pre-processor Definitions
****************************************************************************/
+#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \
Review Comment:
change to error
##########
boards/arm/mps/mps2-an500/include/board.h:
##########
@@ -33,6 +33,12 @@
* Pre-processor Definitions
****************************************************************************/
+#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \
Review Comment:
could you move the warning to the place which is really used it
##########
cmake/nuttx_kconfig.cmake:
##########
@@ -80,7 +80,9 @@ function(nuttx_export_kconfig kconfigfile)
string(REPLACE "${Name}=" "" Value ${NameAndValue})
# remove extra quotes
- string(REPLACE "\"" "" Value ${Value})
+ if(Value)
Review Comment:
why change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
