linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2687083478
########## boards/arm/mps/mps2-an500/include/board.h: ########## @@ -33,6 +33,12 @@ * Pre-processor Definitions ****************************************************************************/ +#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \ Review Comment: Yes, for sim that's true, but if I put this warning there then it will be shown for the simulator (which it shouldn't be, because the simulator is fine with 0). This way it shows exactly which boards are missing the correct value when `grep`-ing as well. I think it's okay to duplicate the code ~10 times since this is a warning message that will be deleted when users provide a calibrated value. That way the warning will not bother users who have set the value to 0 on purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
