xiaoxiang781216 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2687108497
########## boards/arm/mps/mps2-an500/include/board.h: ########## @@ -33,6 +33,12 @@ * Pre-processor Definitions ****************************************************************************/ +#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \ Review Comment: arch_alarm is just a demo place. I would suggest that: 1. Change warning to error in the place where really use this macro 2. Change zero value to a suitable non zero value if it's optional like arch_alarm/arch_timer 3. Add BOARD_LOOPSPERMSEC default value to zero -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
