linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2686871589
########## boards/arm/mps/mps2-an500/include/board.h: ########## @@ -33,6 +33,12 @@ * Pre-processor Definitions ****************************************************************************/ +#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \ Review Comment: I don't think I explained myself well: Some boards don't have a calibrated value for `CONFIG_BOARD_LOOPSPERMSEC`. This is because I don't have access to the board to come up with a value, and no one on the mailing list responded with a value if they owned the board. Since this value is board-specific, I placed a warning in these boards specifically so users who use them will see the warning. It is not possible to put the warning outside of the board-related code because otherwise it will appear in the wrong conditions. Where else you might suggest to put it. ########## boards/arm/mps/mps2-an500/include/board.h: ########## @@ -33,6 +33,12 @@ * Pre-processor Definitions ****************************************************************************/ +#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \ Review Comment: It is specifically used for only these boards which don't have a proper value? I don't understand where else you might suggest to put it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
