acassis commented on code in PR #18233: URL: https://github.com/apache/nuttx/pull/18233#discussion_r2736175385
########## drivers/timers/Kconfig: ########## @@ -30,6 +30,12 @@ config PWM if PWM +config PWM_FREQUENCY_FIXED Review Comment: > > The name PWM_FREQUENCY_FIXED is misleading: seems like a PWM with a frequency that cannot be changed or with an initial frequency fixed. Suggestion change to PWM_FREQUENCY_FP or similar > > @acassis In "frequency fixed", the term "fixed" mainly refers to the fixed-point floating-point implementation found in the "fixedmath.h" file. It is described in Kconfig. Yes, that is the point, FIXED normally is not related to Fixed Point, since you have "FREQUENCY_FIXED". Someone seeing it in the source code will spend some time to figure out that the FREQ is not Fixed, but is is a Fixed Point frequency. Please use FP or if you want to make it more clear: PWM_FREQ_FIXEDPOINT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
