michallenc commented on code in PR #18233:
URL: https://github.com/apache/nuttx/pull/18233#discussion_r2737136853
##########
drivers/timers/Kconfig:
##########
@@ -30,6 +30,12 @@ config PWM
if PWM
+config PWM_FREQUENCY_FIXED
+ bool "PWM Frequency Fixed Point Support"
+ default n
Review Comment:
Should it depend on `CONFIG_HAVE_LONG_LONG`? Otherwise you can select it and
still have plain `uint32_t` for a frequency
##########
Documentation/components/drivers/character/timers/pwm.rst:
##########
@@ -69,7 +69,7 @@ set through ``pwm_info_s`` structure.
struct pwm_info_s
{
/* Frequency of the pulse train */
- uint32_t frequency;
+ pwm_freq_t frequency;
Review Comment:
Please document what type `pwm_freq_t` is as well and how does
`CONFIG_PWM_FREQUENCY_FIXED` affects it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
