acassis commented on code in PR #18233: URL: https://github.com/apache/nuttx/pull/18233#discussion_r2737255344
########## drivers/timers/Kconfig: ########## @@ -30,6 +30,12 @@ config PWM if PWM +config PWM_FREQUENCY_FIXED + bool "PWM Frequency Fixed Point Support" + default n Review Comment: @xiaoxiang781216 that have me an idea: we are wasting much CI time and sometimes the build could break because some missing config. Normally we have in the source code: "#if defined(CONFIG_X) && !defined(CONFIG_Y) #ERROR X depends on Y". That is good and very defensive, but the preprocessor will spend time evaluating many files before spotting the error. Maybe we could create a header file with all these rules to be executed earlier than the evaluation the normal files, this way we will catch the errors earlier and will save time. What do you think, makes sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
