michallenc commented on code in PR #18233:
URL: https://github.com/apache/nuttx/pull/18233#discussion_r2737657089


##########
drivers/timers/Kconfig:
##########
@@ -30,6 +30,12 @@ config PWM
 
 if PWM
 
+config PWM_FREQUENCY_FIXED
+       bool "PWM Frequency Fixed Point Support"
+       default n

Review Comment:
   > can't, since CONFIG_HAVE_LONG_LONG is defined in compiler.h, not Kconfig
   
   ok, then maybe compile time warning placed in pwm header file? Or at least 
some clear warning mentioned in option's help if you don't want to add another 
comptime warning.
   
   I consider these configuration discrepancies as one of the biggest NuttX 
problems. If you can configure it, then it should work - either by native code 
or by some workaround (which can be pretty nasty and I agree we don't want to 
do this) - otherwise the user should be notified the code won't work as 
expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to