Sumit6307 opened a new pull request, #18506: URL: https://github.com/apache/nuttx/pull/18506
This PR addresses several portability and technical debt issues in the mnemofs filesystem by resolving source-level TODO items. Changes: - Implemented a portable fallback for mfs_clz (Count Leading Zeros) in fs/mnemofs/mnemofs.h using a binary search approach. This ensures compatibility with non-GCC compilers where __builtin_clz may not be available. - Removed the redundant 8-bit mfs_arrhash and consolidated hashing with the existing 16-bit mfs_hash in mnemofs_util.c to improve metadata consistency. - Removed the related TODO comments in mnemofs.h and mnemofs_util.c. Impact: - Improves cross-compiler portability for the mnemofs component. - Simplifies the codebase by using a single hashing mechanism. - No changes to the underlying flash format or existing GCC-based builds. Testing: - Verified the portable mfs_clz logic for correctness across the uint32_t range. - Successfully compiled the updated fs/mnemofs files using the NuttX build system. - Tested with the sim (simulator) architecture to confirm build and logic consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
