acassis commented on PR #18506: URL: https://github.com/apache/nuttx/pull/18506#issuecomment-4018839256
> > Hello! > > > Verified the portable mfs_clz logic for correctness across the uint32_t range. > > > > > > Can you please include some logs or more information about how you tested this? > > > Successfully compiled the updated fs/mnemofs files using the NuttX build system. > > > > > > Can you give some information about the configuration you used for this? > > > Tested with the sim (simulator) architecture to confirm build and logic consistency. > > > > > > Could you show some logs from this testing? Which configuration did you use for this? > > Hello @linguini1 , > > Thank you for the review and the helpful suggestions! > > Regarding @acassis's feedback: I have added the Doxygen-style documentation block for the > > mfs_clz > > function in > > fs/mnemofs/mnemofs.h > > as requested, explaining its functionality and return behavior. > > Regarding @linguini1's feedback: > > Verification of > > mfs_clz > > logic: I verified the portable binary search implementation of > > mfs_clz > > using a standalone test script to ensure correctness across various edge cases (0, powers of 2, boundary conditions). > > Verification Logs: > > text Value: 0x00000000 | Leading Zeros: 32 Value: 0x00000001 | Leading Zeros: 31 Value: 0x00000002 | Leading Zeros: 30 Value: 0x00000010 | Leading Zeros: 27 Value: 0x00000100 | Leading Zeros: 23 Value: 0x00010000 | Leading Zeros: 15 Value: 0x10000000 | Leading Zeros: 3 Value: 0x80000000 | Leading Zeros: 0 Value: 0xFFFFFFFF | Leading Zeros: 0 Value: 0x0000FFFF | Leading Zeros: 16 > > Build Configuration: The code was compiled targeting the standard sim:nsh (Simulator) configuration to ensure build consistency within the NuttX tree. Configuration used: > > bash ./tools/configure.sh sim:nsh make > > Simulator Testing: I verified that the > > mnemofs > > module compiles without errors under the sim:nsh configuration. This PR primarily targets foundational bit-logic (Count Leading Zeros) and removes redundant code as per internal TODO suggestions. > > I have pushed these updates to the mnemofs-bit-pr branch. Looking forward to your thoughts! @Sumit6307 thank you, please squash your commits, if you never did it before the steps are listed here: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
