linguini1 commented on PR #18506: URL: https://github.com/apache/nuttx/pull/18506#issuecomment-4019149182
> Verification of > > mfs_clz > > logic: I verified the portable binary search implementation of > > mfs_clz > > using a standalone test script to ensure correctness across various edge cases (0, powers of 2, boundary conditions). > > Verification Logs: > > text > Value: 0x00000000 | Leading Zeros: 32 > Value: 0x00000001 | Leading Zeros: 31 > Value: 0x00000002 | Leading Zeros: 30 > Value: 0x00000010 | Leading Zeros: 27 > Value: 0x00000100 | Leading Zeros: 23 > Value: 0x00010000 | Leading Zeros: 15 > Value: 0x10000000 | Leading Zeros: 3 > Value: 0x80000000 | Leading Zeros: 0 > Value: 0xFFFFFFFF | Leading Zeros: 0 > Value: 0x0000FFFF | Leading Zeros: 16 Nice! Could you attach this script in your test section? > Build Configuration: The code was compiled targeting the standard sim:nsh (Simulator) configuration to ensure build consistency within the NuttX tree. Configuration used: > > bash > ./tools/configure.sh sim:nsh > make > > Simulator Testing: I verified that the > > mnemofs > > module compiles without errors under the sim:nsh configuration. This PR primarily targets foundational bit-logic (Count Leading Zeros) and removes redundant code as per internal TODO suggestions. Okay! I don't think sim:nsh has mnemofs enabled though, can you let us know what configuration options you selected to get it to build? > I have pushed these updates to the mnemofs-bit-pr branch. Looking forward to your thoughts! Which updates? I don't see any new commits added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
