resyfer commented on PR #18506: URL: https://github.com/apache/nuttx/pull/18506#issuecomment-4019547349
@acassis I'm fine with the changes themselves. The work is based on some TODOs I had, and the changes look fine to me. @Sumit6307 please fix the commit naming, PR naming, squash, rebase, and address the failing CI (it's related to your commit as well). As for GSoC, having contributions are good. But they're good because the community would know the developer is familiar with the project among other things. The _developer_, not their tools. That confidence in the developer + their proposal which shows a proper understanding with research into the problem and potential solutions is what gets the person selected as a GSoC contributor. I must stress on this, the developer is the asset here, _not_ their tools. Hope that helps! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
