arjav1528 commented on PR #19050: URL: https://github.com/apache/nuttx/pull/19050#issuecomment-4642732809
> Some of these are really generic identifiers (State, GetState, etc.). Maybe we should find a more permanent solution than just blanket whitelisting them? Can we restrict them to specific library? Maybe certain directories in `apps/` can have `nxstyle.txt` file with a list of identifiers to whitelist in that directory only? > > I just think that the more we add here, the less will be caught later in different apps where these shouldn't be whitelisted. Thoughts? Good point. "State" and "GetState" are way too generic on their own. They're also redundant: the lifecycle_msgs prefix already matches the full mangled identifiers (lifecycle_msgs__srv__GetState_Request, lifecycle_msgs__msg__State, etc.), so dropping the bare ones doesn't lose coverage for this case. I'll amend to keep only lifecycle_msgs and rosidl_runtime_c — both are package-prefixed and unlikely to collide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
