arjav1528 commented on PR #19050:
URL: https://github.com/apache/nuttx/pull/19050#issuecomment-4642948164
> > Good point. "State" and "GetState" are way too generic on their own.
They're also redundant: the lifecycle_msgs prefix already matches the full
mangled identifiers (lifecycle_msgs__srv__GetState_Request,
lifecycle_msgs__msg__State, etc.), so dropping the bare ones doesn't lose
coverage for this case. I'll amend to keep only lifecycle_msgs and
rosidl_runtime_c — both are package-prefixed and unlikely to collide.
> > EDIT : ammended
>
> Idk if that was an LLM answer but that's not my main concern. My concern
is that the ignored symbols should have some way to be restricted to a single
directory (like your micro-ros library in `nuttx-apps`) so that we don't miss
style issues in other code. It seems to me like there are a lot of style issues
that can't be solved with micro-ros, and I'm sure some of those symbols are
going to overlap with other places.
makes sense, I kinda agree that global whitelist has this problem already,
std_msgs, int32, etc. are all same shape, further will collide with anything
else which are using those names. The current PR follows that existing
precedent for microROS bits that I need.
what should I do, like should I land this as is, and open a new PR adding
nxstyle.txt lookup from the source file
or hold this PR, implement the dir-scoped mechanism first, and then ship
lifecycle_msgs only inside the per-dir file
(btw: I agree that the comment you mentioned was almost an LLM ans..
"almost")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
