ppisa commented on issue #18566: URL: https://github.com/apache/nuttx/issues/18566#issuecomment-5392594079
@Acfboy, thanks for the work done and results. I have tested current NuttX mainline code with Nano-X as well as alternative Win API MWdemo modes and result is great. I have read your report as well. Please, submit wrap-up to GSoC site to not miss deadline. Do that at least a few hours in advance for case of some technical problems etc. Big thanks for @ghaerr for his time and willingness to accept and implement changes in Microwindows/Nano-X. I see that documentation and configuration pull request is still in progress state/cleaning https://github.com/apache/nuttx/pull/19912 and that some updates has already been accepted in Microwidows. I expect that making build fully warnings free would require too intrusive changes to Microwindows which have problems to make readability worse and potential in some breakage for other platforms. I think that it is better to tolerate some warnings and keep mainline Microwidows intact (no NuttX local patches). I have noticed some other small problem when I use ``` qemu-system-x86_64 -m 2G -s -enable-kvm -smp 1 \ -cpu host,+pcid,+x2apic,+tsc-deadline,+xsave,+rdrand \ -kernel "$SYSTEM_IMAGE" \ -device qemu-xhci -device usb-kbd -device usb-mouse \ -vga cirrus ``` with ``` CONFIG_USBHOST_HIDKBD=y CONFIG_MICROWINDOWS_KBD_EVENT_PATH="/dev/kbda" ``` then backspace seems to generate some incorrect code/character in MWdemo text input field. I expect that this is related to the recent changes in NuttX keyboard handling (or can be problem caused by some of my configs) and it probably affects some more keys. But this is niche issue which will be solved and needs tuning on real hardware targets anyway. The ground work is done and it is great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
