daniel-p-carvalho commented on PR #20148: URL: https://github.com/apache/nuttx/pull/20148#issuecomment-5742994025
Status update, and a heads-up on what will change in this PR. Following the review here (replace the custom socket ioctls with the generic PTP hardware clock, and use `SO_TIMESTAMPING` for TX timestamps), the original 13 commits have been split up. Everything they contained is now either merged, in its own PR, or dropped: | Original content | Where it went | |---|---| | tickless compare-match race, `adjtime()` slewing from the tickless tick handler | merged as #20173 | | self-transmit loopback false positive in `net/pkt` | merged as #20172 | | `SIOCS_PTP_ADJFREQ` / `SIOCS_PTP_ADJPHASE` | dropped; replaced by the `/dev/ptp0` driver in #20180 | | `SIOCG_TX_HW_TIMESTAMP` | dropped; replaced by `SO_TIMESTAMPING` + `MSG_ERRQUEUE` (#20161, merged) | | RX timestamp ordering, `ETH_MACCR_ROD`, direct hardware counter timestamps, `TMRDEPPATH`/`TMRVPATH` | #20180 | | stale `io_conn` in recycled IOBs (`CONFIG_NET_TIMESTAMPING` typo left behind by #20161) | #20195 | What is left for this PR is the STM32 hardware TX timestamping itself, delivered through `SO_TIMESTAMPING` as defined in #20161. It depends on #20180 (the TX and RX timestamps have to come from the same hardware counter), so I am converting this PR to a draft for now. Once #20180 and #20195 are merged I will rebase the remaining commits onto master, force-push this branch, and update the title and description, so the current diff and the older ioctl-related threads will be outdated by then. The comments above about the ioctl definitions and the `FAR`/cast style in the ioctl code no longer apply, since that code is gone. The `FAR` and cast feedback has been applied to the code that replaced it in #20180. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
