imeghar2408-max commented on PR #3840: URL: https://github.com/apache/nuttx-apps/pull/3840#issuecomment-6129399360
@xiaoxiang781216 I've pushed the refactor in commit `b972648c5`. WAV playback now uses `g_wav_dec_ops` with parser/fill callbacks, and `nxplayer_readbuffer()` dispatches through the decoder's `fill_data` callback rather than a separate WAV branch. The existing MP3/SBC and common PCM paths use adapters to the same callback interface. Validation completed: - SIM ALSA build and link succeeded. - `checkpatch` and `git diff --check` pass. - Valid WAV playback works, and malformed WAV headers/RIFF lengths are rejected. - Raw PCM playback remains supported. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
