imeghar2408-max commented on code in PR #3840: URL: https://github.com/apache/nuttx-apps/pull/3840#discussion_r4259839672
########## system/nxplayer/nxplayer.c: ########## @@ -100,6 +100,66 @@ int nxplayer_getmp3subformat(int fd); #ifdef CONFIG_AUDIO_FORMAT_SBC int nxplayer_getsbcsubformat(int fd); #endif + +static int nxplayer_playfile_impl(FAR struct nxplayer_s *pplayer, + FAR const char *pfilename, int filefmt, + int subfmt, uint8_t nchannels, + uint8_t bpsamp, uint32_t samprate, + uint8_t chmap, bool file_playback); + +#ifdef CONFIG_NXPLAYER_FMT_FROM_EXT +static int nxplayer_parse_mp3_adapter(FAR struct nxplayer_s *pplayer, Review Comment: The existing MP3/SBC callbacks use the old function signatures, while the common decoder interface now passes the player context and allows the parser to return the subformat. I added adapters to bridge the existing callbacks to this interface so WAV could use the same decoder framework without duplicating the dispatch logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
