xiaoxiang781216 commented on code in PR #3840: URL: https://github.com/apache/nuttx-apps/pull/3840#discussion_r4259719834
########## system/nxplayer/nxplayer.c: ########## @@ -100,6 +100,66 @@ int nxplayer_getmp3subformat(int fd); #ifdef CONFIG_AUDIO_FORMAT_SBC int nxplayer_getsbcsubformat(int fd); #endif + +static int nxplayer_playfile_impl(FAR struct nxplayer_s *pplayer, + FAR const char *pfilename, int filefmt, + int subfmt, uint8_t nchannels, + uint8_t bpsamp, uint32_t samprate, + uint8_t chmap, bool file_playback); + +#ifdef CONFIG_NXPLAYER_FMT_FROM_EXT +static int nxplayer_parse_mp3_adapter(FAR struct nxplayer_s *pplayer, Review Comment: why change mp3/adc code ########## system/nxplayer/nxplayer.c: ########## @@ -100,6 +100,66 @@ int nxplayer_getmp3subformat(int fd); #ifdef CONFIG_AUDIO_FORMAT_SBC int nxplayer_getsbcsubformat(int fd); #endif + +static int nxplayer_playfile_impl(FAR struct nxplayer_s *pplayer, + FAR const char *pfilename, int filefmt, + int subfmt, uint8_t nchannels, + uint8_t bpsamp, uint32_t samprate, + uint8_t chmap, bool file_playback); + +#ifdef CONFIG_NXPLAYER_FMT_FROM_EXT +static int nxplayer_parse_mp3_adapter(FAR struct nxplayer_s *pplayer, + int fd, + FAR uint32_t *samplerate, + FAR uint8_t *chans, + FAR uint8_t *bps, + FAR int *subfmt); +static int nxplayer_parse_sbc_adapter(FAR struct nxplayer_s *pplayer, + int fd, + FAR uint32_t *samplerate, + FAR uint8_t *chans, + FAR uint8_t *bps, + FAR int *subfmt); +static int nxplayer_fill_common_adapter(FAR struct nxplayer_s *pplayer, + int fd, + FAR struct ap_buffer_s *apb); +#ifdef CONFIG_AUDIO_FORMAT_PCM +static int nxplayer_parse_wav_adapter(FAR struct nxplayer_s *pplayer, + int fd, + FAR uint32_t *samplerate, + FAR uint8_t *chans, + FAR uint8_t *bps, + FAR int *subfmt); +static int nxplayer_fill_wav_adapter(FAR struct nxplayer_s *pplayer, + int fd, + FAR struct ap_buffer_s *apb); +#endif +#endif + +#if defined(CONFIG_AUDIO_FORMAT_PCM) && \ + defined(CONFIG_NXPLAYER_FMT_FROM_EXT) +static int nxplayer_parse_wav(int fd, FAR uint32_t *samprate, Review Comment: why not move to nxplayer_wav.c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
