imeghar2408-max commented on PR #3840: URL: https://github.com/apache/nuttx-apps/pull/3840#issuecomment-6152143470
Hi @xiaoxiang781216 , thanks for the feedback! I've updated the implementation by moving the WAV-specific RIFF/WAVE parsing, format validation, and PCM buffer-filling logic into a dedicated `nxplayer_wav.c`, integrated with the existing decoder operations framework. The existing MP3/SBC decoder paths and raw PCM playback path have been kept separate from the WAV-specific changes. I've also rebuilt and tested the SIM ALSA configuration, including valid WAV playback with odd-sized chunks, raw PCM playback, malformed WAV rejection, and mid-playback truncation handling. `checkpatch.sh` and `git diff --check` pass. Please have another look when you get a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
