v01d commented on pull request #2215:
URL: https://github.com/apache/incubator-nuttx/pull/2215#issuecomment-725460270


   >     1. When fetch isn't NULL, the intermediate buffer is disabled on 
sensor_register to save ram. Done on this patch.
   
   I see. But the call to the buffer creation function is still done and if I 
understand correctly, due to the rounding up, one struct will be allocated in 
the buffer still.
   
   > 
   >     2. I think we should move towards unification. If there is no 
conforming type or structure, we should add them and make them as versatile as 
possible. It's especially good for application developers.
   > 
   
   I agree, but I'm thinking in the lines of something that wouldn't 
necessarily be ported upstream, leaving downstream user the possibility of 
defining a particular driver with specific needs. But we can go back to this 
later on.
   
   > 
   > Thank you.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to