v01d commented on pull request #2215:
URL: https://github.com/apache/incubator-nuttx/pull/2215#issuecomment-725460869


   > > > I'm looking at the changes. I wanted to ask, any reason why you are 
defining your own queue structure instead of using definitions in queue.h?
   > > 
   > > 
   > > The circualr buffer and queue are different for their behavior. We need 
to overwrite old data when buffer is full, and it's better to operate buffer 
directly rather than queue node.
   > 
   > I will add mm/circ_buf for circular buffer management on other patch 
later, and driver/sensor and driver/rc will call these api about circ_buf_xxx 
to use circular buffer.
   
   Are you sure there's no circular buffer structure defined anywhere else in 
NuttX?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to