davids5 commented on a change in pull request #5104:
URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776371181
##########
File path: net/tcp/Kconfig
##########
@@ -50,11 +50,11 @@ config NET_TCPURGDATA
compiled in. Urgent data (out-of-band data) is a rarely used
TCP feature
that is very seldom would be required.
-config NET_TCP_CONNS
- int "Number of TCP/IP connections"
- default 8
+config NET_TCP_CONNS_PER_BLOCK
+ int "Number of TCP/IP connections per block(one for each open)"
+ default 4
---help---
- Maximum number of TCP/IP connections (all tasks)
+ Maximum number of TCP/IP connections per block(all tasks)
Review comment:
What aboutn NET_{UDP|TCP}_CONNS_PER_BLOCK ->
NET_{UDP|TCP}_CONNS_PER_ALLOC so it is consistent with this behavior that is
not the same as the FD change that is blocks?
##########
File path: net/tcp/Kconfig
##########
@@ -50,11 +50,11 @@ config NET_TCPURGDATA
compiled in. Urgent data (out-of-band data) is a rarely used
TCP feature
that is very seldom would be required.
-config NET_TCP_CONNS
- int "Number of TCP/IP connections"
- default 8
+config NET_TCP_CONNS_PER_BLOCK
+ int "Number of TCP/IP connections per block(one for each open)"
+ default 4
---help---
- Maximum number of TCP/IP connections (all tasks)
+ Maximum number of TCP/IP connections per block(all tasks)
Review comment:
What about NET_{UDP|TCP}_CONNS_PER_BLOCK ->
NET_{UDP|TCP}_CONNS_PER_ALLOC so it is consistent with this behavior that is
not the same as the FD change that is blocks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
