xiaoxiang781216 commented on a change in pull request #5104:
URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776734912
##########
File path: net/tcp/tcp_conn.c
##########
@@ -110,15 +107,12 @@ static FAR struct tcp_conn_s *
tcp_listener(uint8_t domain, FAR const union ip_addr_u *ipaddr,
uint16_t portno)
{
- FAR struct tcp_conn_s *conn;
- int i;
+ FAR struct tcp_conn_s *conn = NULL;
/* Check if this port number is in use by any active UIP TCP connection */
- for (i = 0; i < CONFIG_NET_TCP_CONNS; i++)
+ while ((conn = tcp_nextconn(conn)) != NULL)
Review comment:
Should we protect DoS from the server level? Since it's hard to estimate
a good value when multiple servers run at the same time. Also, many servers
support limitation of the concurrent connection by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
