anchao commented on a change in pull request #5104:
URL: https://github.com/apache/incubator-nuttx/pull/5104#discussion_r776451230



##########
File path: net/udp/Kconfig
##########
@@ -50,11 +50,11 @@ config NET_UDP_CHECKSUMS
                Enable/disable UDP checksum support.  UDP checksum support is
                REQUIRED for IPv6.
 
-config NET_UDP_CONNS
-       int "Number of UDP sockets"
-       default 8
+config NET_UDP_CONNS_PER_BLOCK
+       int "Number of UDP sockets per block(one for each open)"
+       default 4
        ---help---
-               The maximum amount of open concurrent UDP sockets
+               The maximum amount of open concurrent UDP sockets per block

Review comment:
       Done

##########
File path: net/udp/Kconfig
##########
@@ -50,11 +50,11 @@ config NET_UDP_CHECKSUMS
                Enable/disable UDP checksum support.  UDP checksum support is
                REQUIRED for IPv6.
 
-config NET_UDP_CONNS
-       int "Number of UDP sockets"
-       default 8
+config NET_UDP_CONNS_PER_BLOCK
+       int "Number of UDP sockets per block(one for each open)"
+       default 4

Review comment:
       Done

##########
File path: net/tcp/Kconfig
##########
@@ -50,11 +50,11 @@ config NET_TCPURGDATA
                compiled in. Urgent data (out-of-band data) is a rarely used 
TCP feature
                that is very seldom would be required.
 
-config NET_TCP_CONNS
-       int "Number of TCP/IP connections"
-       default 8
+config NET_TCP_CONNS_PER_BLOCK
+       int "Number of TCP/IP connections per block(one for each open)"
+       default 4
        ---help---
-               Maximum number of TCP/IP connections (all tasks)
+               Maximum number of TCP/IP connections per block(all tasks)

Review comment:
       Done

##########
File path: net/tcp/Kconfig
##########
@@ -50,11 +50,11 @@ config NET_TCPURGDATA
                compiled in. Urgent data (out-of-band data) is a rarely used 
TCP feature
                that is very seldom would be required.
 
-config NET_TCP_CONNS
-       int "Number of TCP/IP connections"
-       default 8
+config NET_TCP_CONNS_PER_BLOCK
+       int "Number of TCP/IP connections per block(one for each open)"
+       default 4

Review comment:
       Done

##########
File path: net/udp/udp_conn.c
##########
@@ -62,6 +62,8 @@
 #include <nuttx/net/ip.h>
 #include <nuttx/net/udp.h>
 
+#include <nuttx/kmalloc.h>

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to