fjpanag commented on code in PR #7436:
URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1005910938


##########
arch/arm/src/armv7-m/arm_stackcheck.c:
##########
@@ -69,6 +69,12 @@ void __stack_overflow_trap(void)
 
   uint32_t regval;
 
+  regval = getreg32(NVIC_DHCSR);

Review Comment:
   It is too late if you stop at the hardfault handler. You do not know the 
cause of the fault (it may be anything else, not only this trap).
   
   Also stopping before the interrupt call means that the debugger can access 
the context of the offending task, you can look around and better understand 
the issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to