[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7436: arm: Added breakpoint in stack overflow trap.

[GitBox]

xiaoxiang781216 commented on code in PR #7436:
URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1005973950


##########
arch/arm/src/armv8-m/arm_stackcheck.c:
##########
@@ -69,6 +69,12 @@ void __stack_overflow_trap(void)
 
   uint32_t regval;
 
+  regval = getreg32(NVIC_DHCSR);
+  if (regval & 0x01)

Review Comment:
   it's better to add macro to nvic.h instead using magic number here directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org