[GitHub] [incubator-nuttx] davids5 commented on a diff in pull request #7436: arm: Added breakpoint in stack overflow trap.

[GitBox]

davids5 commented on code in PR #7436:
URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1006751444


##########
arch/arm/src/armv7-m/arm_stackcheck.c:
##########
@@ -69,6 +69,12 @@ void __stack_overflow_trap(void)
 
   uint32_t regval;
 
+  regval = getreg32(NVIC_DHCSR);

Review Comment:
   Well it does add overhead and Unlimited Flash Breakpoint are available on 
Segger's Jlink. 
   
   The Build is soo big that that 16 bytes could break it. 
   
   Kconfig works for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org