[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7436: arm: Added breakpoint in stack overflow trap.

[GitBox]

fjpanag commented on code in PR #7436:
URL: https://github.com/apache/incubator-nuttx/pull/7436#discussion_r1006709088


##########
arch/arm/src/armv7-m/arm_stackcheck.c:
##########
@@ -69,6 +69,12 @@ void __stack_overflow_trap(void)
 
   uint32_t regval;
 
+  regval = getreg32(NVIC_DHCSR);

Review Comment:
   Building without this PR:
   ```
      text         data     bss     dec     hex filename
    863483         3900   48352  915735   df917 bin/firmware
   ```
   
   Building with this PR:
   ```
      text         data     bss     dec     hex filename
    863499         3900   48352  915751   df927 bin/firmware
   ```
   
   This is a 16 byte difference in text only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org