TimJTi opened a new pull request, #9252:
URL: https://github.com/apache/nuttx/pull/9252

   ## Summary
   Adds driver for Microchip ATSAMA5D2 and D4 processors. The ATSAMA5D3 does 
not have "secure fuse" support so a different driver would be needed for that 
device, or a lot more #ifdef clutter added.
   
   ## Impact
   None expected. But NB: no testing has been done on an ATSAMA5D4 processor.
   
   ## Testing
   Custom board with ATSAMA5D27C-D1G. Various fuse patterns tested and verified.
   
   ## Things I am not sure of
   1) The comments in `include/nuttx/efuse.h` say the fuse fields
   `are mapped inside an arch efuse table and referenced in a header file 
inside include/nuttx/efuse/ directory
   `
   I am not sure that is really the right place for this, but I have created a 
generic header file and placed it there, but think it perhaps should be located 
in `arch/arm/src/sama5/hardware` instead?
   
   2) A lot of the functionality came from existing code for the esp32c3 
familly. There might be an argument for someone, sometime, to extract the 
common functions and relocate them as helper functions as part of the overall 
efuse support? That said, I think the esp32c3 efuse code has bugs in it....
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to