TimJTi commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1191344535
########## arch/arm/src/sama5/hardware/sam_sfc.h: ########## Review Comment: > Would that make sense to show a warning if `SAMA5` is selected but not `ATSAMA5D2` or `ATSAMA5D4` so people would know other chips does not support eFuse (yet)? I put the check in sam_sfc.c at the top (line 51). Perhaps it should be in the header file instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
