TimJTi commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1191352569
########## arch/arm/src/sama5/hardware/sam_sfc.h: ########## Review Comment: > > Would that make sense to show a warning if `SAMA5` is selected but not `ATSAMA5D2` or `ATSAMA5D4` so people would know other chips does not support eFuse (yet)? > > This would result in warnings (which are elevated to errors) for every other member of the family. > > Normally, you would make the chip part of the Kconfig dependency and simply not allow eFuse to be selected unless it is supported by the chip. SAMA5D4 should work - I just haven't checked it hence the compiler warning in sam_sfc.c. I could demote to info? But I don't want anyone thinking it will "just work" - I have spent to long fixing things when I make that assumption! I have made sure it can't be selected in Kconfig for SAMA5D3 though, so the warning should not be triggered for that device. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
