TimJTi commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1191347584
########## arch/arm/src/sama5/hardware/sam_sfc.h: ########## Review Comment: > > Would that make sense to show a warning if `SAMA5` is selected but not `ATSAMA5D2` or `ATSAMA5D4` so people would know other chips does not support eFuse (yet)? > > This would result in warnings (which are elevated to errors) for every other member of the family. > > Normally, you would make the chip part of the Kconfig dependency and simply not allow eFuse to be selected unless it is supported by the chip. I did make sure SFC could not be selected in Kconfig for SAMA5D3...I like to bomb-proof stuff whenever possible so did put a warning as mentioned. I could demote to info or remove entirely? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
