pussuw commented on code in PR #11165:
URL: https://github.com/apache/nuttx/pull/11165#discussion_r1390941495
##########
libs/libc/sched/CMakeLists.txt:
##########
@@ -26,11 +26,11 @@ set(SRCS
clock_timespec_add.c
clock_timespec_subtract.c
clock_getcpuclockid.c
- clock_getres.c)
-
-if(NOT CONFIG_CANCELLATION_POINTS)
Review Comment:
The way it worked previously:
- There were two versions of task_setcanceltype.c and task_testcancel.c, one
in sched/task and one in libc/sched
- If cancelpoints=y then the sched/task versions are compiled, if
cancelpoints=n then the libc versions are compiled
- The libc versions were just dummies that do nothing, besides provide the
task_setcanceltype() and task_testcancel() symbols for compilation
- Now there is only 1 version, in libc, which means the libc version must
always be compiled, otherwise the symbols are missing and the code will not
compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
